Skip to content

Remove quicktester #6712

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Remove quicktester #6712

wants to merge 2 commits into from

Conversation

Girgias
Copy link
Member

@Girgias Girgias commented Feb 20, 2021

This is barely used and more of a hinderence than anything else

nikic
nikic reviewed Feb 20, 2021
View reviewed changes
@Girgias
Copy link
Member Author

Girgias commented Feb 20, 2021

Seems the JIT is segfaulting.

@nikic
Copy link
Member

nikic commented Feb 20, 2021

ext/standard/tests/math/abs.phpt:

009+ DASM_S_RANGE_VREG
010+ php: /home/vsts/work/1/s/ext/opcache/jit/zend_jit.c:311: handle_dasm_error: Assertion `0' failed.
011+ Aborted (core dumped)
012+ 
013+ Termsig=6

Looks like we're trying to emit invalid assembly.

@nikic
Copy link
Member

nikic commented Feb 22, 2021

Bug report: https://bugs.php.net/bug.php?id=80782

@Girgias
Remove quicktester
41bed79 
This is barely used and more of a hinderence than anything else
@Girgias
Remove useless check in epislon_equal func
c4a9e36
@php-pulls php-pulls closed this in 3a4b896 Feb 25, 2021
@Girgias Girgias deleted the remove-quicktester branch February 25, 2021 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nikic nikic nikic left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Girgias @nikic